Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(pb): change gen path and use message key as bytes instead of string #184

Closed
wants to merge 1 commit into from
Closed

fix(pb): change gen path and use message key as bytes instead of string #184

wants to merge 1 commit into from

Conversation

90dy
Copy link

@90dy 90dy commented Aug 8, 2018 •
edited
Loading

Fix #177

@90dy 90dy force-pushed the fix/protobuf-utf-8-enforce branch from 973fa27 to 2d9ea5d Compare August 8, 2018 09:17
@90dy
Copy link
Author

90dy commented Aug 8, 2018

I just realized that PR #183 fix the same issue with dependencies on PR from other repositories

@90dy 90dy mentioned this pull request Aug 8, 2018
Merged
@Stebalien
Copy link
Member

Yeah, this is a non-trivial cross-repo change (which is why I've been dragging my feet on it for a while). It'll hopefully be done by the end of the day.

@Stebalien
Copy link
Member

This has now been fixed.

@Stebalien Stebalien closed this Aug 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@90dy @Stebalien